This repository was archived by the owner on Nov 4, 2024. It is now read-only.
OBR script changes#177
Open
Tom-Slattery wants to merge 3 commits into
Open
Conversation
Signed-off-by: Tom Slattery <tom.slattery@ibm.com>
eamansour
reviewed
Sep 16, 2024
eamansour
approved these changes
Sep 16, 2024
eamansour
left a comment
eamansour
left a comment
Contributor
There was a problem hiding this comment.
Approved subject to resolving the above comment
Signed-off-by: Tom Slattery <tom.slattery@ibm.com>
Author
|
Addressed the GPG Passphrase with the new commit. Also wanted to mention that I've added extensions to the dependency download step as that wasn't in my original comment: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OBR script seems to set the value of GALASA_BUILD_TOOL_PATH using the get_galasabld_binary_location method, then overwrite that value for each method that uses galasabld. This causes the script to fail for me when galasabld is on my path. I've removed the extra setting of GALASA_BUILD_TOOL_PATH and used the value obtained by get_galasabld_binary_location.
For each mvn call I've added:
--settings ${WORKSPACE_DIR}/obr/settings.xml
-Dgpg.skip=true \
So that maven uses the settings.xml file in the workspace, allowing the value of galasa.source.repo and galasa.central.repo to be use (otherwise this fails for me).
I've also skipped gpg signing here as the maven calls seem to only pull from remote Maven and build to local Maven - signing didn't seem necessary here.